Fix: webhook DELETE handler crash — undefined params variable#98
Closed
FuturMix wants to merge 1 commit into
Closed
Fix: webhook DELETE handler crash — undefined params variable#98FuturMix wants to merge 1 commit into
FuturMix wants to merge 1 commit into
Conversation
The DELETE handler references a bare `params` variable that is not defined in scope. The withAuth middleware passes Next.js context as event.context, so route params must be accessed via `await event.context.params` (async in Next.js 15). Without this fix, deleting a webhook always crashes with ReferenceError: params is not defined. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #97
The
DELETEhandler insrc/app/api/webhooks/[id]/route.jsreferences a bareparamsvariable that doesn't exist in the handler's scope. ThewithAuthmiddleware passes Next.js context asevent.context, and in Next.js 15paramsis a Promise.Changes
src/app/api/webhooks/[id]/route.js: Changedconst { id } = params→const { id } = (await event.context?.params) || {}Test plan
DELETE /api/webhooks/<id>with valid auth — should return 200 instead of crashing🤖 Generated with Claude Code