fix: use response.json() instead of response.NextResponse.json() in Telnyx webhook#92
Closed
FuturMix wants to merge 1 commit into
Closed
fix: use response.json() instead of response.NextResponse.json() in Telnyx webhook#92FuturMix wants to merge 1 commit into
FuturMix wants to merge 1 commit into
Conversation
…elnyx webhook The sendTelnyxResponse function incorrectly calls response.NextResponse.json() which throws a TypeError at runtime since NextResponse is not a property of the fetch Response object. This prevents error details from being logged when the Telnyx API returns an error response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
src/app/api/webhooks/telnyx/sms/route.js, thesendTelnyxResponsefunction callsresponse.NextResponse.json()on line 221 when handling Telnyx API errors.NextResponseis not a property of the fetchResponseobject — this throws aTypeErrorat runtime, preventing error details from being logged.Fix
Changed
response.NextResponse.json()→response.json().Impact
Without this fix, any Telnyx API error during SMS response sends causes an unhandled exception in the error logging path, masking the actual API error.