Fix: escape URLs in url-link-converter HTML output#100
Closed
FuturMix wants to merge 1 commit into
Closed
Conversation
The convertUrlsToLinks function places matched URLs directly into HTML without escaping. While the regex excludes most HTML metacharacters, the & character can appear in query strings and should be escaped as & for valid HTML. Apply escapeHtml() to both the href attribute value and the display text for defense-in-depth. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #99
The
convertUrlsToLinksfunction inserts matched URLs directly into HTML without escaping. URLs with&in query strings produce invalid HTML. This applies the existingescapeHtml()function to both thehrefattribute and display text.Changes
src/lib/utils/url-link-converter.js: Pass URL throughescapeHtml()before inserting into anchor tagTest plan
https://example.com?a=1&b=2renders as a valid clickable link🤖 Generated with Claude Code