Classify RSS media enclosures as podcasts#45
Open
lazyGPT07 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
podcastWhy
The XML parser removes namespace prefixes, so checking for
itunes:authoris not reliable. RSS podcast enclosures also normally live on individual items rather than the channel. As a result, valid podcast feeds were returned withkind: "blog".Impact
Feed discovery now labels ordinary RSS podcast feeds correctly without changing blog classification for feeds that lack media enclosures.
Validation
npm run buildnpm test(68 tests passed)Closes #44