Skip to content

Handle invalid CLI limit options #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Autowebassat-blip wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −4
Open

Handle invalid CLI limit options #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ program
{ type: "TASK", board, title: "QA checkout flow", meta: "25 USDC" },
{ type: "POST", board, title: "New agent plugin idea", meta: "4 replies" },
{ type: "RUN", board, title: "qa-agent completed task_123", meta: "completed" }
].slice(0, Number(options.limit)),
].slice(0, parsePositiveIntegerOption(options.limit, 20)),
options.format as OutputFormat
);
});
Expand Down Expand Up @@ -316,8 +316,8 @@ feeds
const response = await discoverFeeds({
q: keyword,
type: options.type as FeedKind | "all",
limit: Number(options.limit),
freshnessDays: options.freshnessDays ? Number(options.freshnessDays) : undefined,
limit: parsePositiveIntegerOption(options.limit, 25),
freshnessDays: options.freshnessDays ? parsePositiveIntegerOption(options.freshnessDays, undefined) : undefined,
includeDeadFeeds: Boolean(options.includeDeadFeeds),
includeUnvalidated: Boolean(options.includeUnvalidated),
providers: splitOption(options.providers)
Expand Down Expand Up @@ -365,7 +365,7 @@ feeds
.option("--limit <limit>", "Maximum results", "100")
.description("Discover feeds and print OPML.")
.action(async (keyword, options) => {
const response = await discoverFeeds({ q: keyword, limit: Number(options.limit) });
const response = await discoverFeeds({ q: keyword, limit: parsePositiveIntegerOption(options.limit, 100) });
console.log(renderDiscoveryOutput(response, "opml"));
});

Expand Down Expand Up @@ -602,6 +602,13 @@ function splitOption(value: string | undefined) {
.filter(Boolean);
}

function parsePositiveIntegerOption(value: string | undefined, fallback: number): number;
function parsePositiveIntegerOption(value: string | undefined, fallback: undefined): number | undefined;
function parsePositiveIntegerOption(value: string | undefined, fallback: number | undefined) {
const parsed = Number(value);
return Number.isFinite(parsed) && parsed > 0 ? Math.trunc(parsed) : fallback;
}

async function runYoloArcade(game: string, repo?: string) {
const task: TaskSnapshot = {
id: "agentswarm_yolo",
Expand Down
Loading