Skip to content

Require CoinPay userinfo identity before session#21

Open
phucnguyen1707 wants to merge 1 commit into
profullstack:masterfrom
phucnguyen1707:require-coinpay-userinfo-sub
Open

Require CoinPay userinfo identity before session#21
phucnguyen1707 wants to merge 1 commit into
profullstack:masterfrom
phucnguyen1707:require-coinpay-userinfo-sub

Conversation

@phucnguyen1707

@phucnguyen1707 phucnguyen1707 commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #22.

Summary

  • require CoinPay OAuth userinfo to include a subject before creating a signed session
  • redirect with userinfo_failed instead of setting an ambiguous authenticated session
  • add a contract test for missing-sub userinfo responses

Test

  • npm --workspace @logicsrc/web run test:contract

@phucnguyen1707 phucnguyen1707 mentioned this pull request Jun 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CoinPay OAuth can create a session without a user subject

1 participant

@phucnguyen1707