Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/commandboard-api/src/contract.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ describe("CommandBoard API contracts", () => {
const providersBody = await providersResponse.json() as { providers: Array<{ id: string; enabledByDefault: boolean }> };
const discoverResponse = await fetch(`${baseUrl}/api/feeds/discover?q=microsaas&providers=manual-curated&includeUnvalidated=true`);
const discoverBody = await discoverResponse.json() as { query: string; results: Array<{ feedUrl: string; provider: string }> };
const invalidLimitResponse = await fetch(`${baseUrl}/api/feeds/discover?q=microsaas&limit=-1&providers=manual-curated&includeUnvalidated=true`);
const invalidLimitBody = await invalidLimitResponse.json() as { results: Array<{ feedUrl: string; provider: string }> };
const rssResponse = await fetch(`${baseUrl}/rss/discover/microsaas.xml?providers=manual-curated&includeUnvalidated=true`);
const rssBody = await rssResponse.text();
const opmlResponse = await fetch(`${baseUrl}/opml/discover/microsaas.xml?providers=manual-curated&includeUnvalidated=true`);
Expand All @@ -94,6 +96,8 @@ describe("CommandBoard API contracts", () => {
expect(discoverResponse.status).toBe(200);
expect(discoverBody.query).toBe("microsaas");
expect(discoverBody.results[0]).toMatchObject({ provider: "manual-curated" });
expect(invalidLimitResponse.status).toBe(200);
expect(invalidLimitBody.results[0]).toMatchObject({ provider: "manual-curated" });
expect(rssResponse.status).toBe(200);
expect(rssBody).toContain("<rss");
expect(opmlResponse.status).toBe(200);
Expand Down
2 changes: 1 addition & 1 deletion apps/commandboard-api/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ function numberParam(value: string | null) {
return undefined;
}
const parsed = Number(value);
return Number.isFinite(parsed) ? parsed : undefined;
return Number.isFinite(parsed) && parsed > 0 ? parsed : undefined;
}

function listParam(value: string | null) {
Expand Down
Loading