fix(validators): isSchemaKind no longer accepts inherited prototype keys#14
Merged
ralyodio merged 1 commit intoJun 12, 2026
Merged
Conversation
'value in schemas' walks the prototype chain, so inherited keys like "toString" passed assertSchemaKind and then crashed ajv.compile with a misleading 'schema must be object or boolean' error (e.g. via the CLI). Use Object.hasOwn for an own-property check. Adds unit tests rejecting prototype keys and asserting every real schema kind still passes. Fixes profullstack#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
Summary
isSchemaKindusedvalue in schemas, which walks the prototype chain — inherited keys liketoString/constructorpassedassertSchemaKindand then crashedajv.compilewith a misleadingschema must be object or booleanerror (reachable via thelogicsrc-validateCLI).Changes
Object.hasOwn(schemas, value)own-property checktoString/constructor/valueOf/hasOwnPropertywith the intendedUnknown schema kinderror; every real schema kind still acceptedTesting
Applied via the ugig gig — ugig user
liudong-design.