Repository navigation
desktop: open OSC 8 links without the confirm prompt (0.4.2) - #17
Merged
Merged
Conversation
xterm.js's default OSC 8 linkHandler asks confirm() and then window.open()s about:blank before setting location, which setWindowOpenHandler denies — so shift+clicking a hyperlink prompted and then did nothing. Route it through hq.openUrl like plain-text URLs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift+clicking an OSC 8 hyperlink popped xterm.js's default "This link could potentially be dangerous" confirm(), and then nothing opened: the default handler calls
window.open()with no URL, and main'ssetWindowOpenHandlerdeniesabout:blank.Adds a
linkHandlerto the Terminal that sends the URI tohq.openUrl(same path as plain-text URLs via WebLinksAddon; main still only opens http/https). Bumps to 0.4.2.🤖 Generated with Claude Code