Repository navigation
fix(desktop): Linux icon never found on KDE (hicolor/1254x1254) - #57
Merged
Merged
Conversation
The deb installed its only icon at hicolor/1254x1254/apps/, because electron-builder files a single PNG under its pixel size and the source is 1254px. No index.theme lists that directory, so KDE drew a generic icon in the menu, on the desktop and in the taskbar. - linux.icon now points at resources/icons/, a 16-512 set of real hicolor sizes, so the deb ships eight standard icon paths. - linux.desktop flattened to the map electron-builder 25 reads; the nested `entry` (v26 syntax) was stringified into `entry=[object Object]` and the Keywords line was lost. - The tarball carries the same set (extraResources), and install.sh installs every size, tracked in the manifest so uninstall removes them; bundles before this still get the single 512x512 copy. - Tests guard the flat desktop map and that every icon is a hicolor size and really that size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DiskPush icon showed as generic on Kubuntu/KDE.
Cause. The deb put its only icon at
hicolor/1254x1254/apps/diskpush-desktop.png. electron-builder files a single PNG under its pixel size, and the source is 1254px. Noindex.themelists a 1254x1254 directory, so Plasma never found the icon.Also,
linux.desktop.entryis electron-builder 26 syntax. Version 25 turned it into the stringentry=[object Object]in the .desktop file, and the Keywords line was lost.Fix
linux.icon→resources/icons/: a set of 16 to 512px icons in real hicolor sizes. The deb now installs 8 standard paths.linux.desktopflattened. The deb's entry now hasKeywords=andStartupWMClass=DiskPush, and the junk line is gone.install.shinstalls every size and records each one in the manifest so uninstall removes it. Older bundles fall back to the single 512x512 copy.Verified locally. Built the deb and tar.gz with
package-desktop.mjsand inspected the deb's .desktop file and icon paths. Ran the installer's icon loop against the extracted tarball.pnpm test: 796/797 pass. The one failure istests/live/rsync-behaviouron this box's umask 007, and it passes with umask 022.🤖 Generated with Claude Code