Repository navigation
fix(ads): ref_slug no longer truncates past campaign 999 - #358
Merged
Merged
Conversation
lpad(seq::text, 3, '0') truncates longer strings, so campaign 1000 became crawlproof-ad-100 and every new campaign hit ad_campaigns_ref_slug_key. Pad to at least three digits; existing slugs are unchanged. Applied to prod. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ralyodio
force-pushed
the
fix-ad-ref-slug-past-999
branch
from
October 14, 2026 21:35
4446567 to
9131a7d
Compare
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a campaign failed with
duplicate key value violates unique constraint "ad_campaigns_ref_slug_key".ref_slugwas'crawlproof-ad-' || lpad(seq::text, 3, '0'), andlpadtruncates, so seq 1000 →crawlproof-ad-100(already taken). Campaign 999 was created 2026-10-13; every insert since failed (sequence had climbed to 1067).Migration switches to
lpad(seq::text, greatest(3, length(seq::text)), '0')via PG17SET EXPRESSION. All 869 existing slugs unchanged; test insert givescrawlproof-ad-1068. Already applied to prod (dev2 supabase-db). App regexes already accept\d+.🤖 Generated with Claude Code