Skip to content

Enable MediaElement updatePixels test - #9264

Merged
limzykenneth merged 1 commit into
processing:mainfrom
BhumitSahani:fix/mediaelement-updatepixels-test
Oct 9, 2026
Merged

limzykenneth merged 1 commit into
processing:mainfrom
BhumitSahani:fix/mediaelement-updatepixels-test

Conversation

@BhumitSahani

Copy link
Copy Markdown
Contributor

Changes

  • Enabled the existing p5.MediaElement updatePixels() test.
  • Added the DOM module to the existing test mock so createImg() is available without importing the full p5 module.
  • Kept the existing media-element test structure and headless-video workaround unchanged.
  • This allows the existing test to run using only the modules required by the mock.

Testing

  • npx vitest run test/unit/dom/p5.MediaElement.js
  • npx vitest run test/unit/dom
  • npm run lint
  • npm test

PR Checklist

  • npm run lint passes
  • Unit tests are included / updated

Copilot AI balanced review requested due to automatic review settings October 8, 2026 18:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@BhumitSahani

Copy link
Copy Markdown
Contributor Author

@limzykenneth Thanks for your guidance on this. I've enabled the existing MediaElement updatePixels() test using the DOM module attached to the existing mock, without importing the full p5 module. The relevant tests and npm test are passing. Would appreciate your review.

@p5-bot

p5-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

Continuous Release

CDN link

Published Packages

Commit hash: d90baa0

Previous deployments

This is an automated message.

@limzykenneth
limzykenneth merged commit 8ae967b into processing:main Oct 9, 2026
4 checks passed
@limzykenneth

Copy link
Copy Markdown
Member

Looks good. Thanks!

@BhumitSahani

Copy link
Copy Markdown
Contributor Author

@allcontributors please add @BhumitSahani for code.

@allcontributors

Copy link
Copy Markdown
Contributor

@BhumitSahani

I've put up a pull request to add @BhumitSahani! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants