Repository navigation
Enable MediaElement updatePixels test - #9264
Merged
limzykenneth merged 1 commit intoOct 9, 2026
Merged
limzykenneth merged 1 commit into
limzykenneth merged 1 commit into
Conversation
Contributor
Author
|
@limzykenneth Thanks for your guidance on this. I've enabled the existing MediaElement updatePixels() test using the DOM module attached to the existing mock, without importing the full p5 module. The relevant tests and npm test are passing. Would appreciate your review. |
Continuous ReleaseCDN linkPublished PackagesCommit hash: d90baa0 Previous deploymentsThis is an automated message. |
Member
|
Looks good. Thanks! |
Contributor
Author
|
@allcontributors please add @BhumitSahani for code. |
Contributor
|
I've put up a pull request to add @BhumitSahani! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
p5.MediaElementupdatePixels()test.createImg()is available without importing the full p5 module.Testing
npx vitest run test/unit/dom/p5.MediaElement.jsnpx vitest run test/unit/domnpm run lintnpm testPR Checklist
npm run lintpasses