fix linting warnings - #9103
Open
Vaivaswat2244 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Vaivaswat <vaivaswat2244@gmail.com>
Continuous ReleaseCDN linkPublished PackagesCommit hash: c8f12be Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves partially: #9070
Changes:
Fixes all 143 oxlint warnings; npm run lint now exits clean. No lint config was changed. Every warning was resolved in code.
Mostly mechanical:
One behaviour change worth review:
Renderer3Ddeclaredremove()twice. The first (canvas teardown, added in 2fa995a) was silently shadowed by a second added later in ef28cbc for_textCanvas, sowrappedEltcleanup has never run. I merged them,Renderer2D.remove()has the identical four lines, which is what it was meant to mirror. WebGL/WebGPU canvases are now actually detached on remove().Two edits look behavioural but aren't: return FES.internalError(...) is unreachable (it always throws), and if (0) → if (debug) in textCore.js uses a param that arrives falsy.
Screenshots of the change:
PR Checklist
Verification
WebGPU visual cases and p5.RendererWebGPU were not run locally cuz no software WebGPU adapter available :) leaving those to CI.