Skip to content

fix linting warnings - #9103

Open
Vaivaswat2244 wants to merge 2 commits into
processing:mainfrom
Vaivaswat2244:fix/lint-warnings
Open

fix linting warnings#9103
Vaivaswat2244 wants to merge 2 commits into
processing:mainfrom
Vaivaswat2244:fix/lint-warnings

Conversation

@Vaivaswat2244

@Vaivaswat2244 Vaivaswat2244 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Resolves partially: #9070

Changes:

Fixes all 143 oxlint warnings; npm run lint now exits clean. No lint config was changed. Every warning was resolved in code.

Mostly mechanical:

  • unused imports, variables and orphaned functions removed
  • bare catch {} for unused catch params
  • == → ===
  • // falls through on intentional switch fallthroughs
  • { } around case bodies containing declarations
  • dead if (0) blocks and unreachable post-throw code deleted

One behaviour change worth review: Renderer3D declared remove() twice. The first (canvas teardown, added in 2fa995a) was silently shadowed by a second added later in ef28cbc for _textCanvas, so wrappedElt cleanup has never run. I merged them, Renderer2D.remove() has the identical four lines, which is what it was meant to mirror. WebGL/WebGPU canvases are now actually detached on remove().

Two edits look behavioural but aren't: return FES.internalError(...) is unreachable (it always throws), and if (0) → if (debug) in textCore.js uses a param that arrives falsy.

Screenshots of the change:

image

PR Checklist

  • npm run lint passes
  • [Inline reference] is included / updated — N/A, no public API changes
  • [Unit tests] are included / updated — N/A, no behaviour to cover; existing suites pass unchanged
Verification
  • npm run lint -> 0 warnings (was 143)
  • npm run build -> passes
  • unit-tests -> 2098 passed, 0 failed
  • webgpu p5.Shader + p5.Framebuffer -> 105 passed, 0 failed

WebGPU visual cases and p5.RendererWebGPU were not run locally cuz no software WebGPU adapter available :) leaving those to CI.

Vaivaswat2244 and others added 2 commits August 21, 2026 00:12
Signed-off-by: Vaivaswat <vaivaswat2244@gmail.com>
@p5-bot

p5-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

Continuous Release

CDN link

Published Packages

Commit hash: c8f12be

Previous deployments

This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant