Handle strands set() calls in branches and loops#8576
Merged
davepagurek merged 1 commit intodev-2.0from Feb 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8573
Changes:
=statements. But calling.set(...), a new construct, doesn't get noticed as part of that.=OR.set()calls in loops and branching, instead this transpiles away.set()calls in loops/branches to use an intermediate variable outside the loop, assign to it normally inside the loop, and then call.set()on the result at the end.let something;intermediate variables that don't have a type. Previously they worked only if you use them as a "flat" dependency, i.e. you assign them directly with a value. If you have a conditional update where you assign it to either itself or a real value, then we get a nested dependency, and it breaks. So now we recursively update types when you do that, so that all nested dependencies get type info.Screenshots of the change:
Live: https://editor.p5js.org/davepagurek/sketches/iY_hzGaAj
PR Checklist
npm run lintpasses