Fix 404 on localized library directory page#1520
Merged
Merged
Conversation
Contributor
Author
|
Hi @ksen0 , |
Contributor
|
Hi @Ayush4958, thank you for this PR. I tested it locally and can confirm that /es/libraries/directory/, which previously returned a 404, now loads correctly, and all other non-English locales work as expected. |
Member
|
Thanks @Nwakaego-Ego for review and @Ayush4958 for the work! PS If you find other places on the site where the localization page is missing, please feel free to make a new PR adding those, and link to this PR/issue for context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The corresponding
[locale]dynamic route file was missing for thedirectorysubdirectory, this resulted in a 404 page.Added the missing
src/pages/[locale]/libraries/directory/index.astrolocalized route.Closes :- #1517
Screen Recording
Screen.Recording.2026-07-19.010212.mp4