Improve speed of CI tests with cacheing#4211
Open
clairep94 wants to merge 3 commits into
Open
Conversation
clairep94
changed the title
clairep94
marked this pull request as ready for review
July 19, 2026 00:30
clairep94
commented
Jul 19, 2026
Comment on lines
+87
to
+97
| - name: Cache wait-on | ||
| uses: actions/cache@v4 | ||
| id: wait-on-cache | ||
| with: | ||
| path: ~/.npm/_npx | ||
| key: npx-wait-on-${{ env.WAIT_ON_VERSION }}-${{ runner.os }} | ||
|
|
||
| - name: Install wait-on | ||
| if: steps.wait-on-cache.outputs.cache-hit != 'true' | ||
| run: npx -y wait-on@$WAIT_ON_VERSION --version | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
previously we were doing the wait-on install in ln 103
I separated it in case cacheing it would help
I don't think it makes a huge difference (3s) but also doesn't hurt
clairep94
commented
Jul 19, 2026
Comment on lines
-10
to
-15
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@v1 | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'npm' | ||
|
|
||
| - name: Create .env file | ||
| run: cp .env.example .env | ||
|
|
||
| - name: Cache node_modules | ||
| uses: actions/cache@v4 | ||
| id: node-modules-cache | ||
| with: | ||
| node-version: '18.20.x' | ||
| - run: npm install |
Collaborator
Author
There was a problem hiding this comment.
checkout v2 and setup-node v1 are really old so I bumped them both up to 4 to match e2e.yml. Also wasn't sure if cache@v4 required these to be v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #
Demo:
test.yml before vs after hitting the node_modules cache
e2e.yml before and after hitting the node_modules cache
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123