GSOC: e2e.yml add environment: e2e-tests to gate test runs via reviewer approval#4209
Open
clairep94 wants to merge 2 commits into
Open
GSOC: e2e.yml add environment: e2e-tests to gate test runs via reviewer approval#4209clairep94 wants to merge 2 commits into
clairep94 wants to merge 2 commits into
Conversation
…pproval. remove temporary comment trigger
Collaborator
Author
|
@raclim updating the e2e.yml test file after our call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes # GSOC project setup
Demo:
Changes:
environment: e2e-teststo e2e.yml file --> this env has been configured on the github UI for "Required Reviewers" to be @Geethegreat, @clairep94, @khanniie or @raclim for the remainder of GSOCI have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123