fix(linter): Fix false errors for numeric separators (underscores, eg: 2_000_000)#3737
Closed
Shubhashish-Chakraborty wants to merge 6 commits intoprocessing:developfrom
Closed
Conversation
Author
Author
Member
|
Hi Shubhashish! Happy new year : ) I'm a contributor to the project, but not the lead, so I'm not the right person to review this. Thanks! |
Author
|
aah Alright, my bad😅 |
Collaborator
|
Sorry for taking a while to get back on this and thank you so much for giving this a go! I think we might not be moving forward with this solution since we currently plan to refactor the |
Author
|
Alright sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3709
Problem: The code linter (JSHint) was incorrectly flagging valid ES2021 numeric separators (e.g., 1_000_000) as syntax errors. This resulted in red underlines and "Unexpected '_'" messages in the editor, even though the syntax is valid and supported in modern JavaScript.Changes:(CodeMirror.lint.javascript)to act as a "middleman." This allows your code to catch the error report before it gets sent to the editor interface.(using the regex /\d+_\d+/). If found, it specifically filters out "unexpected token" or "underscore" errors, ensuring only real syntax errors are shown to the user.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123