feat: agentic engineering at prisma blogs#7844
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds an Agentic Engineering MDX blog post and wires Mermaid support into the blog MDX pipeline by importing and enabling ChangesBlog Content & Rendering
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/blog/src/components/Mermaid.tsx`:
- Around line 3-29: The component declaration and use of useMemo in export async
function Mermaid(...) violates Rules of Hooks; change Mermaid to a plain
synchronous component (remove async) and remove useMemo, call
renderMermaidSVG(chart, ...) directly inside a try/catch; on catch return the
existing CodeBlock/Pre fallback (using the chart) and on success return the div
with dangerouslySetInnerHTML using the svg string; keep references to the same
props shape ({ chart }: { chart: string }) and reuse renderMermaidSVG,
CodeBlock, and Pre identifiers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ac3d8316-f3e6-492c-ac04-7ec457a477fb
⛔ Files ignored due to path filters (6)
apps/blog/public/agentic-engineering-at-prisma/imgs/hero.svgis excluded by!**/*.svgapps/blog/public/agentic-engineering-at-prisma/imgs/meta.pngis excluded by!**/*.pngapps/blog/public/authors/tyler-hogarth.pngis excluded by!**/*.pngapps/blog/public/drive-and-the-maker/imgs/hero.svgis excluded by!**/*.svgapps/blog/public/drive-and-the-maker/imgs/meta.pngis excluded by!**/*.pngpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (7)
apps/blog/content/blog/agentic-engineering-at-prisma/index.mdxapps/blog/content/blog/drive-and-the-maker/index.mdxapps/blog/package.jsonapps/blog/source.config.tsapps/blog/src/components/Mermaid.tsxapps/blog/src/mdx-components.tsxpnpm-workspace.yaml
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/blog/src/components/Mermaid.tsx (1)
12-12: Evaluate whether SVG sanitization is necessary for Mermaid charts.Line 12 uses
dangerouslySetInnerHTMLwith unsanitized SVG fromrenderMermaidSVG. While this is an injection point, the actual risk depends on the data source: chart data comes from curated MDX files within the repository, not from untrusted external input. Thebeautiful-mermaid@1.1.3library has no known vulnerabilities per Snyk, though it doesn't explicitly guarantee XSS-safe output in its documentation.If chart data will remain sourced only from internal documentation files, the current implementation is acceptable. However, if there's any possibility of chart data ever coming from user input, API responses, or untrusted sources in the future, adding client-side SVG sanitization (e.g.,
DOMPurify) would be prudent defensive programming to future-proof the component.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/blog/src/components/Mermaid.tsx` at line 12, The Mermaid component currently injects raw SVG via dangerouslySetInnerHTML using renderMermaidSVG output; to harden this, import a sanitizer (e.g., DOMPurify or isomorphic-dompurify) and run the SVG through it before assigning to dangerouslySetInnerHTML — either sanitize inside the Mermaid component just before returning the <div> or inside renderMermaidSVG when it produces the string; ensure you call sanitize(svg, { SAFE_FOR_TEMPLATES: true }) (or equivalent) and use the sanitized string for __html, and if your app does server-side rendering use isomorphic-dompurify or guard for window before using DOMPurify and add the dependency to package.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/blog/src/components/Mermaid.tsx`:
- Line 12: The Mermaid component currently injects raw SVG via
dangerouslySetInnerHTML using renderMermaidSVG output; to harden this, import a
sanitizer (e.g., DOMPurify or isomorphic-dompurify) and run the SVG through it
before assigning to dangerouslySetInnerHTML — either sanitize inside the Mermaid
component just before returning the <div> or inside renderMermaidSVG when it
produces the string; ensure you call sanitize(svg, { SAFE_FOR_TEMPLATES: true })
(or equivalent) and use the sanitized string for __html, and if your app does
server-side rendering use isomorphic-dompurify or guard for window before using
DOMPurify and add the dependency to package.json.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fca44d95-e509-424d-bdf8-5d2e1b875322
📒 Files selected for processing (1)
apps/blog/src/components/Mermaid.tsx
4 participants
Summary by CodeRabbit
New Features
Documentation