Repository navigation
Conversation
🦋 Changeset detectedLatest commit: c23e8e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
adierkens
changed the base branch from
adierkens-primer-trigger-composition
to
main
November 13, 2026 21:23
adierkens
force-pushed
the
adierkens-tooltip-suppression
branch
from
November 13, 2026 21:23
e168018 to
6f247d2
Compare
adierkens
had a problem deploying
to
github-pages
November 13, 2026 21:28 — with
GitHub Actions
Failure
github-actions
Bot
requested a deployment
to
storybook-preview-8754
November 13, 2026 21:28
Abandoned
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested a deployment
to
storybook-preview-8754
November 13, 2026 21:37
Abandoned
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to github/core-ux#4233.
Add public suppression to the main
TooltipAPI, preserving trigger behavior and accessible text. This PR is independent of trigger composition.Changelog
New
Tooltip.disabledcloses visible bubbles, cancels pending opens, and prevents reopening without disabling its trigger. Standard Tooltip examples demonstrate suppression and configured menu anchors.Changed
disabledor_privateDisableTooltipbeing true suppresses the tooltip. Re-enabling requires fresh interaction; accessible naming/descriptions remain intact. Private suppression also closes visible bubbles, and repeated hover no longer leaves orphaned opening timers.disabledand migrate IconButton's internal tooltip suppression to the public prop; compatibility remains covered.Removed
None. No controlled visibility, trigger-composition, or bubble-props API is introduced.
Rollout strategy
Testing & Reviewing
Passed on the standalone main-based branch:
npm run build,npm run type-check,npm test -- --run(3,101 tests),npm run lint:npm --workspace @primer/react,npm run lint:fix,npm run lint:css,npm run format,npm run format:diff, andgit diff --check. The packaged declaration retains the deprecation pointer. Focused IconButton/Tooltip tests passed (103 tests).Both stable stories were rendered and exercised in Chromium. Axe + GitHub checks passed settled visible-tooltip, suppressed-tooltip, and open-menu states. Manual screen-reader checks and canonical AVT/VRT were not run; the full accessibility review remains incomplete. Storybook MCP was unavailable; local browser verification was used.