Repository navigation
feat: add useScrollAnchor with an interactive demo - #8753
Draft
tay1orjones wants to merge 2 commits into
Draft
tay1orjones wants to merge 2 commits into
tay1orjones wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 64f72b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
integration-tests: recommended
Contributor
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes github/primer#6306
Keep the comment you're reading in place when earlier content loads, including in browsers without native scroll anchoring.
useScrollAnchoris opt-in, so existing consumers are unchanged.Changelog
New
useScrollAnchor({containerRef, anchorRef})preserves an element's viewport position as its container changes.Changed
Removed
Rollout strategy
Adoption plan:
IssueTimelinesupplies the timeline container ref and a visible comment ref, owns anchor selection, and reconciles its existing Safari workaround. Upgrading Primer alone won't change timeline behavior.Testing & Reviewing
Open Hooks/useScrollAnchor → Scroll Anchor. Scroll to the highlighted comment, load earlier comments, and toggle the hook to compare. Native scroll anchoring is disabled in the demo to isolate the hook's behavior. Only window scrolling is supported.
Focused hook tests and TypeScript checking pass. Real Safari scrolling and hash-navigation behavior still need verification. Incomplete local dependencies block the build, linting, and Storybook preview.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com