Skip to content

(experiment) bring modern styles for button - #8734

Draft
siddharthkp wants to merge 17 commits into
mainfrom
siddharthkp-match-shortcut-button-padding
Draft

siddharthkp wants to merge 17 commits into
mainfrom
siddharthkp-match-shortcut-button-padding

Conversation

@siddharthkp

@siddharthkp siddharthkp commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Exploring what the diff would look like and how can we serve the css. Using button as experiment

siddharthkp and others added 9 commits November 9, 2026 23:27
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore the active ButtonBase stylesheet and component to main while retaining the modern stylesheet for a future override layer.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the original stylesheet unchanged and the full modern reference unused. Apply a small CSS Module layer for all-size spacing while preserving inline Link sizing and joined keyboard hints.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f85ebba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

siddharthkp and others added 4 commits November 10, 2026 15:47
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions
github-actions Bot requested a deployment to storybook-preview-8734 November 10, 2026 14:52 Abandoned
siddharthkp and others added 2 commits November 10, 2026 15:55
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions
github-actions Bot requested a deployment to storybook-preview-8734 November 10, 2026 15:01 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8734 November 10, 2026 15:25 Inactive
@siddharthkp siddharthkp changed the title ignore (experiment) bring modern styles for button Nov 11, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 14, 2026

This branch was successfully deployed

2 active (outdated) deployments
storybook-preview-8734 — d5d7628c Deployed Nov 13, 2026 by github-actions[bot]
github-pages — d5d7628c Deployed Nov 13, 2026 by siddharthkp via deploy-preview #34300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member update snapshots 🤖 Command that updates VRT snapshots on the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant