Prevent virtualized SelectPanel measurement warnings - #8429
Open
tay1orjones wants to merge 1 commit into
Open
tay1orjones wants to merge 1 commit into
tay1orjones wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tay1orjones
requested review from
siddharthkp
and
a lite review from Copilot
and removed request for
Copilot
September 18, 2026 18:03
🦋 Changeset detectedLatest commit: 6fff099 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
|
Integration test results from github/github-ui PR:
All checks passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8424
Virtualized SelectPanel items were forwarding their measurement ref to both the indexed list item and an unindexed inner element, causing TanStack Virtual to emit a console warning. Route list-semantic refs only to the outer list item so measurement uses the expected element.
Changelog
New
Changed
data-indexmeasurement warnings.Removed
Rollout strategy
Testing & Reviewing
Full build, unit tests, type-check, lint, CSS lint, and formatting checks pass. The
VirtualizedBuiltInStorybook example was also exercised in Chromium and no longer emits the measurement warning while scrolling.