Skip to content

Prevent virtualized SelectPanel measurement warnings - #8429

Open
tay1orjones wants to merge 1 commit into
mainfrom
tay1orjones-fix-virtualized-select-panel-warning
Open

tay1orjones wants to merge 1 commit into
mainfrom
tay1orjones-fix-virtualized-select-panel-warning

Conversation

@tay1orjones

Copy link
Copy Markdown
Contributor

Closes #8424

Virtualized SelectPanel items were forwarding their measurement ref to both the indexed list item and an unindexed inner element, causing TanStack Virtual to emit a console warning. Route list-semantic refs only to the outer list item so measurement uses the expected element.

Changelog

New

  • N/A

Changed

  • Prevent virtualized SelectPanel items from logging missing data-index measurement warnings.
  • Add regression coverage for ActionList ref routing and virtualized item measurement.

Removed

  • N/A

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Full build, unit tests, type-check, lint, CSS lint, and formatting checks pass. The VirtualizedBuiltIn Storybook example was also exercised in Chromium and no longer emits the measurement warning while scrolling.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@tay1orjones
tay1orjones requested a review from a team as a code owner September 18, 2026 18:03
@tay1orjones
tay1orjones requested review from siddharthkp and a lite review from Copilot and removed request for Copilot September 18, 2026 18:03
@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6fff099

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  Changes   Passed
Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@github-actions github-actions Bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtualized SelectPanel logs missing data-index warning

1 participant