Skip to content

Migrate initial components to mergeProps - #8256

Draft
joshblack wants to merge 1 commit into
migrate/merge-props-migratorfrom
migrate/merge-props-batch-01
Draft

Migrate initial components to mergeProps#8256
joshblack wants to merge 1 commit into
migrate/merge-props-migratorfrom
migrate/merge-props-batch-01

Conversation

@joshblack

@joshblack joshblack commented Jul 31, 2026

Copy link
Copy Markdown
Member

Closes #

This PR contains the first bounded ADR-025 implementation batch. It migrates three reviewed component patterns without mixing changes into the tooling foundation or migration driver.

Changelog

New

Changed

  • Update VisuallyHidden to merge component and consumer class names through mergeProps.
  • Update TokenBase to run component keyboard behavior before consumer handlers while keeping refs separate.
  • Update Radio to preserve radio semantics and compose context and consumer change handlers.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

These changes correct existing component behavior to match the intended contracts. They do not add a supported public capability, so this batch does not include release notes.

Testing & Reviewing

Please review class-name ordering, optional handler composition, ref handling, and the Radio type invariant. The migration report should no longer list the three assigned source files.

Apply the validated class name, event handler, ref, and component-owned prop patterns in a dedicated implementation batch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 00bfd295-6ed9-4119-8d63-103a0b3c63e8
@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f791ad9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Jul 31, 2026
@joshblack joshblack added the skip changeset This change does not need a changelog label Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant