Add experimental React RelativeTime - #8250
Draft
adierkens wants to merge 5 commits into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bfa22b31-cbe2-4b07-8add-f302af4c1a2b
Contributor
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bfa22b31-cbe2-4b07-8add-f302af4c1a2b
🦋 Changeset detectedLatest commit: 63d5e4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bfa22b31-cbe2-4b07-8add-f302af4c1a2b
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bfa22b31-cbe2-4b07-8add-f302af4c1a2b
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bfa22b31-cbe2-4b07-8add-f302af4c1a2b
|
Integration test results from github/github-ui PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changelog
New
ExperimentalRelativeTimeis available from@primer/react/experimentalfor opt-in evaluation of the native React implementation.primer_react_relative_timeto evaluate the implementation through the establishedRelativeTimeentry point.Changed
RelativeTimecomponent continues to render the existing<relative-time>custom element and retains its dependency, props, callback event contract, refs, and serialized formatting attributes by default.<time>, and uses Intl APIs for formatting and live updates. It preserves itsdata-componentanddatetimecontract; it intentionally does not reproduce legacy formatting attributes. If rollout diagnostics need DOM metadata, add a dedicateddata-relative-time-*contract rather than reviving custom-element attributes.Removed
Rollout strategy
Testing & Reviewing
ff7297694showed 297 DataTable failures across 99 snapshots (three retries each). The stable default had reverted to<relative-time>, while the prior mask only targeted the experimental<time>shape. Commitfba412b2emasks both shapes; no baselines were regenerated.