Skip to content

feat: add CSS Layer support to overlay consumers#7960

Draft
joshblack wants to merge 2 commits into
css-layers/09-button-action-listfrom
css-layers/10-overlay-consumers
Draft

feat: add CSS Layer support to overlay consumers#7960
joshblack wants to merge 2 commits into
css-layers/09-button-action-listfrom
css-layers/10-overlay-consumers

Conversation

@joshblack

@joshblack joshblack commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of https://github.com/github/primer/issues/6275

Migrates AnchoredOverlay, Autocomplete, Banner, Blankslate, Breadcrumbs, Dialog, ActionMenu, ActionBar, and SelectPanel2 styles into named Primer component CSS layers.

Changelog

New

  • Adds CSS layer coverage for AnchoredOverlay, Autocomplete, Banner, Blankslate, Breadcrumbs, Dialog, ActionMenu, ActionBar, and SelectPanel2.

Changed

  • Wraps AnchoredOverlay, Autocomplete, Banner, Blankslate, Breadcrumbs, Dialog, ActionMenu, ActionBar, and SelectPanel2 CSS module styles in named @layer primer.components.* layers.

Removed

  • None

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • Run cd packages/react && npx vitest run src/__tests__/css-layers.test.ts --config vitest.config.mts.
  • Review this PR as part of the CSS layers stack; this entry covers AnchoredOverlay, Autocomplete, Banner, Blankslate, Breadcrumbs, Dialog, ActionMenu, ActionBar, and SelectPanel2.

Merge checklist

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@joshblack joshblack changed the title feat: add CSS Layers to 10-overlay-consumers feat: add CSS Layer support to overlay consumers Jun 9, 2026
@joshblack joshblack force-pushed the css-layers/09-button-action-list branch from fbb44d0 to 5ceff2f Compare June 9, 2026 20:14
@joshblack joshblack force-pushed the css-layers/10-overlay-consumers branch from 44d6819 to 146cfdf Compare June 9, 2026 20:14
@changeset-bot

changeset-bot Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 385bd71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@github-actions github-actions Bot requested a deployment to storybook-preview-7960 June 9, 2026 20:19 Abandoned
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the css-layers/09-button-action-list branch from 5ceff2f to 5c14b60 Compare June 9, 2026 20:24
@joshblack joshblack force-pushed the css-layers/10-overlay-consumers branch 2 times, most recently from 26feaa4 to 385bd71 Compare June 9, 2026 20:27
@joshblack joshblack force-pushed the css-layers/09-button-action-list branch from 5c14b60 to 03d6006 Compare June 9, 2026 20:27
@github-actions github-actions Bot requested a deployment to storybook-preview-7960 June 9, 2026 20:28 Abandoned
joshblack and others added 2 commits June 9, 2026 15:28
@joshblack
feat: add CSS Layers to 10-overlay-consumers
d9c1d28 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack
chore: standardize CSS layer changeset wording
a37f74c 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack joshblack force-pushed the css-layers/09-button-action-list branch from 03d6006 to dc6acbb Compare June 9, 2026 20:29
@joshblack joshblack force-pushed the css-layers/10-overlay-consumers branch from 385bd71 to a37f74c Compare June 9, 2026 20:29
@github-actions github-actions Bot requested a deployment to storybook-preview-7960 June 9, 2026 20:33 Abandoned
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joshblack