Skip to content

feat: add CSS Layer support to Button prerequisites#7958

Draft
joshblack wants to merge 2 commits into
css-layers/07-text-token-foundationsfrom
css-layers/08-button-prerequisites
Draft

feat: add CSS Layer support to Button prerequisites#7958
joshblack wants to merge 2 commits into
css-layers/07-text-token-foundationsfrom
css-layers/08-button-prerequisites

Conversation

@joshblack

@joshblack joshblack commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of https://github.com/github/primer/issues/6275

Migrates KeybindingHint, Spinner, Textarea, TextInput, ToggleSwitch, Token, TextInputWithTokens, and TooltipV2 styles into named Primer component CSS layers.

Changelog

New

  • Adds CSS layer coverage for KeybindingHint, Spinner, Textarea, TextInput, ToggleSwitch, Token, TextInputWithTokens, and TooltipV2.

Changed

  • Wraps KeybindingHint, Spinner, Textarea, TextInput, ToggleSwitch, Token, TextInputWithTokens, and TooltipV2 CSS module styles in named @layer primer.components.* layers.

Removed

  • None

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • Run cd packages/react && npx vitest run src/__tests__/css-layers.test.ts --config vitest.config.mts.
  • Review this PR as part of the CSS layers stack; this entry covers KeybindingHint, Spinner, Textarea, TextInput, ToggleSwitch, Token, TextInputWithTokens, and TooltipV2.

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 07c512b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@joshblack joshblack changed the title feat: add CSS Layers to 08-button-prerequisites feat: add CSS Layer support to Button prerequisites Jun 9, 2026
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the css-layers/07-text-token-foundations branch from 5400205 to b278746 Compare June 9, 2026 20:14
@joshblack joshblack force-pushed the css-layers/08-button-prerequisites branch from b3a3526 to 8e9bd1e Compare June 9, 2026 20:14
@github-actions github-actions Bot requested a deployment to storybook-preview-7958 June 9, 2026 20:19 Abandoned
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the css-layers/07-text-token-foundations branch from b278746 to 9ad191c Compare June 9, 2026 20:24
@joshblack joshblack force-pushed the css-layers/08-button-prerequisites branch 2 times, most recently from 41085b2 to 07c512b Compare June 9, 2026 20:27
@joshblack joshblack force-pushed the css-layers/07-text-token-foundations branch from 9ad191c to 19ae830 Compare June 9, 2026 20:27
@github-actions github-actions Bot requested a deployment to storybook-preview-7958 June 9, 2026 20:28 Abandoned
joshblack and others added 2 commits June 9, 2026 15:28
@joshblack
feat: add CSS Layers to 08-button-prerequisites
1195048 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack
chore: standardize CSS layer changeset wording
72ab09d 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack joshblack force-pushed the css-layers/08-button-prerequisites branch from 07c512b to 72ab09d Compare June 9, 2026 20:29
@joshblack joshblack force-pushed the css-layers/07-text-token-foundations branch from 19ae830 to 88bcfd7 Compare June 9, 2026 20:29
@github-actions github-actions Bot requested a deployment to storybook-preview-7958 June 9, 2026 20:33 Abandoned
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joshblack