Skip to content

feat: add CSS Layer support to PageLayout#7955

Draft
joshblack wants to merge 2 commits into
css-layers/04-layout-foundations-afrom
css-layers/05-page-layout
Draft

feat: add CSS Layer support to PageLayout#7955
joshblack wants to merge 2 commits into
css-layers/04-layout-foundations-afrom
css-layers/05-page-layout

Conversation

@joshblack

@joshblack joshblack commented Jun 9, 2026

Copy link
Copy Markdown
Member

Part of https://github.com/github/primer/issues/6275

Migrates PageLayout styles into named Primer component CSS layers.

Changelog

New

  • Adds CSS layer coverage for PageLayout.

Changed

  • Wraps PageLayout CSS module styles in named @layer primer.components.* layers.

Removed

  • None

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • Run cd packages/react && npx vitest run src/__tests__/css-layers.test.ts --config vitest.config.mts.
  • Review this PR as part of the CSS layers stack; this entry covers PageLayout.

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 29db7bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@joshblack joshblack changed the title feat: add CSS Layers to 05-page-layout feat: add CSS Layer support to PageLayout Jun 9, 2026
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the css-layers/04-layout-foundations-a branch from c081170 to 7b76a23 Compare June 9, 2026 20:14
@joshblack joshblack force-pushed the css-layers/05-page-layout branch from 56e76ad to 4c00529 Compare June 9, 2026 20:14
@github-actions github-actions Bot temporarily deployed to storybook-preview-7955 June 9, 2026 20:19 Inactive
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the css-layers/04-layout-foundations-a branch from 7b76a23 to 1f44908 Compare June 9, 2026 20:24
@joshblack joshblack force-pushed the css-layers/05-page-layout branch from 4c00529 to e936376 Compare June 9, 2026 20:24
@github-actions github-actions Bot requested a deployment to storybook-preview-7955 June 9, 2026 20:27 Abandoned
@joshblack joshblack force-pushed the css-layers/04-layout-foundations-a branch from 1f44908 to f6ee46d Compare June 9, 2026 20:27
@joshblack joshblack force-pushed the css-layers/05-page-layout branch from e936376 to c25bf0e Compare June 9, 2026 20:27
joshblack and others added 2 commits June 9, 2026 15:28
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack joshblack force-pushed the css-layers/04-layout-foundations-a branch from f6ee46d to 7c570b2 Compare June 9, 2026 20:29
@joshblack joshblack force-pushed the css-layers/05-page-layout branch from c25bf0e to 29db7bc Compare June 9, 2026 20:29
@github-actions github-actions Bot requested a deployment to storybook-preview-7955 June 9, 2026 20:31 Abandoned
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant