WIP: Add primer_react_css_contain_portal feature flag#7363
Closed
mattcosta7 wants to merge 7 commits intomainfrom
Closed
WIP: Add primer_react_css_contain_portal feature flag#7363mattcosta7 wants to merge 7 commits intomainfrom
mattcosta7 wants to merge 7 commits intomainfrom
Conversation
When enabled, applies `contain: layout style` to Portal elements to improve rendering performance by isolating layout and style calculations. The containment does not clip overflow, so dropdowns/tooltips continue to work correctly. - Added useFeatureFlag check in Portal component - Added useLayoutEffect to apply/remove containment based on flag - Added comprehensive tests for the feature flag behavior
🦋 Changeset detectedLatest commit: 410b0cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
github-actions
Bot
requested a deployment
to
storybook-preview-7363
github-actions
Bot
requested a deployment
to
storybook-preview-7363
github-actions
Bot
requested a deployment
to
storybook-preview-7363
mattcosta7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabled, applies
contain: layout styleto Portal elements to improve rendering performance by isolating layout and style calculations. The containment does not clip overflow, so dropdowns/tooltips continue to work correctly.Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist