fix: keep state mutations on one file - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENCODE_GOAL_STATE_PATHonce per queued mutation so reads and writes cannot target different filesRoot cause
An in-flight continuation from a prior test could begin a state mutation against fixture A.
readStateEffectread A, butwriteStateEffectresolved the environment variable again and wrote the old state into fixture B after the next test changedOPENCODE_GOAL_STATE_PATH. Captured failures showed objectives from earlier tests inside the current test's newly-created path.The regression was observed RED before the fix (
original objectiveremained in A and updated state moved to B) and GREEN after capturing one path for the mutation.Validation
bun run lintbun run typecheckbun run test(213 pass)bun run test:coverage(213 pass)bun run buildbun run pack:dry-run