[43081j]

Passes the manual config through normal config resolution such that
overrides are evaluated and respected.

Fixes #124

[pkg-pr-new]

Open in StackBlitz

yarn add https://pkg.pr.new/@prettier/cli@125.tgz

commit: 7d85b6b

[fisker]

Have you tested how the classic CLI works? I think it makes sense to solve files from the config path.

[43081j]

do you have an example? i'm not sure i follow.

you're saying prettier --config ~/config.json foo.js should resolve ~/foo.js? that doesn't seem right.

this is just fixing a bug: we weren't resolving overrides for manual configs at all, i.e. they were completely skipped. so this branch now resolves them

[fisker]

Classic CLI uses --config, not --config-path, a known bug?

https://prettier.io/docs/next/cli#--find-config-path-and---config

[43081j]

this has always used --config from when Fabio first made it, i just assumed it was on purpose to make it clearer what it is. i don't think it can be considered a bug, its just a choice to be made

[fisker]

12deacf

[fisker]

do you have an example? i'm not sure i follow.

>cat config/prettier.json
{
  "semi": true,
  "overrides": [
    {
      "files": "src/*.js",   # <-- this should only apply to `config/src/*.js`, no matter where Prettier runs
      "options": {
        "semi": false
      }
    }
  ]
}

>node bin/prettier --config=config/prettier.json src/foo.js
const x = "foo"; # <-- still prints semiconlon

>node bin/prettier --config=config/prettier.json config/src/foo.js
const x = "foo" # <-- no semicolon

[43081j]

ok @fisker i've updated it:

• overrides are now relative to their config file
• fixed a bug during that where we weren't clearing overrides before adding the normalised ones
• added some test cases to cover this

[fisker]

why not just a//b/ or foo bar instead of src//lib/

[43081j]

no particular reason. its just what i was testing it against so the fixture ended up the same name.

happy to change it if needed

[fisker]

I didn't look into the implementation details, but the result looks good.