fix: perform format operation in chunks - #115
Merged
Merged
Conversation
cellison-figma
changed the title
43081j
reviewed
Jul 30, 2026
43081j
approved these changes
Aug 17, 2026
commit: |
fisker
reviewed
Aug 17, 2026
Member
|
Is |
Contributor
Author
|
@fisker sorry, that was me missing it in the update. Restored. |
fisker
reviewed
Sep 3, 2026
Co-authored-by: fisker Cheung <lionkay@gmail.com>
fisker
reviewed
Sep 3, 2026
fisker
reviewed
Sep 3, 2026
| await Promise.all(Array.from({ length: runnersCount }, runNext)); | ||
|
|
||
| return results; | ||
| } |
Member
There was a problem hiding this comment.
@43081j Did you review the implementation of this function? It doesn't feel correct to me.
Collaborator
There was a problem hiding this comment.
its a shame we need it but thats more a fault of Node not having any built-in capability for it.
the implementation seems fine to me 👍
basically kicks off runnersCount functions which iterate until the queue is drained.
Co-authored-by: fisker Cheung <lionkay@gmail.com>
fisker
approved these changes
Sep 3, 2026
Member
There was a problem hiding this comment.
I'm not sure about #115 (comment), other changes looks good to me, I'll leave this to @43081j
43081j
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Maps file formatting with concurrency, bound to passed in parallel worker count or CPU count minus one (as fallback). This replaces the previous unbounded
Promise.allSettled& addresses an outstanding TODO comment. Cache reads, config resolution, file contents, and formatting jobs are still bound together. Errors still settle independently, and results retain their original file order.The concurrency mapper has added tests to cover core functionality.
This resolves issue #114