Repository navigation
Conversation
On Windows, spawning pixi with shell: true failed when the executable path contained a space (e.g. C:\Users\First Last\.pixi\bin\pixi.exe), because only the arguments were quoted. Quote the executable with the existing quoteStringIfNecessary helper. Fixes prefix-dev#8 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pixi's executable path was not quoted, so a space in it (for example
C:\Users\First Last\...) broke every Pixi call. I tested the issue and the fix on my laptop (Windows 11, username is two space-separated words), and the fix worked.AI-assisted details (written with Claude Code)
Fixes #8.
Change (
src/pixi/utils.ts, 2 lines)spawncall. The unquoted path still goes intoexecInfo, so tools that spawn without a shell (e.g. Black Formatter) keep working. Users who applied the "quote the setting" workaround should remove the quotes, because quoted values break those tools (see the Fails on Windows, when there is a space in the home directory path #8 comment).shell: trueis intentionally kept as is. Moving toshell: falsewould change behaviour and is out of scope.Checks
npm run lint,npm run format:checkandnpm run compileall pass.Testing
C:\Users\First Last\.pixi\bin\pixi.EXE(pixiExecutableempty), project onD:\.'C:\Users\First' is not recognized …in the Pixi Environment Manager output, and no Pixi environments.pixi --versionsucceeds during activation, the Pixi manager registers,LearningMLDL:defaultis listed under Pixi, and a cmd terminal activates it with"C:\…\pixi.EXE" shell --manifest-path … -e default.Notes
src/pixi/utils.tsbut not this line, so any conflict should be trivial.🤖 Generated with Claude Code