Migration from Bootstrap3.3.7 to Bootstrap 5.3.8#921
Migration from Bootstrap3.3.7 to Bootstrap 5.3.8#921MuhammadAashirAslam wants to merge 3 commits into
Conversation
- Upgraded Bootstrap from 3.3.7 to 5.3.8 CDN bundle (CSS & JS) in head layouts and removed obsolete IE8/9 compatibility layers.
- Simplified HTML layouts by deleting nested row/column wrappers ("div-soup") around section headers, paragraph tags, and obsolete caret helper elements.
- Replaced custom CSS classes with modern native Bootstrap 5 grid, flexbox, and alignment utilities (e.g., col-flex -> d-flex flex-column, vertical-align -> d-flex align-items-center, no-margin -> m-0).
- Consolidated main styles by deleting modern-business.css and merging rules into customstyles.css.
- Purged duplicate CSS rules, legacy browser vendor prefixes, and obsolete panel/card dual-class selectors from stylesheets.
- Compensated for spacing changes by shifting the 20px bottom-margin from the removed headers globally to the .section-header class.
- Realigned page footer components, custom workshops, and team grids using standard Bootstrap 5 container, rounding, and spacing parameters.
Documentation:
- BS5 Migration: https://getbootstrap.com/docs/5.3/migration/
- Grid System: https://getbootstrap.com/docs/5.3/layout/grid/
- Cards (replacing Panels): https://getbootstrap.com/docs/5.3/components/card/
- Spacing: https://getbootstrap.com/docs/5.3/utilities/spacing/
- Flexbox: https://getbootstrap.com/docs/5.3/utilities/flex/
- Dropdowns: https://getbootstrap.com/docs/5.3/components/dropdowns/
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Thanks for opening the PR! I had a quick look over the rendering, here are some issues I spotted.
I have not yet looked in detail, let me know once you are ready for a review.
There was a problem hiding this comment.
Two issues on the landing page:
The borders on these cards (and any other) seems to be of a different blue than before. Is that set somewhere, or default?
Overlapping text.
There was a problem hiding this comment.
Do we still need all these themes? If not, feel free to remove.
There was a problem hiding this comment.
Removed both theme-blue.css and theme-green.css
There was a problem hiding this comment.
The sidebar does something strange: when I click on a collapsed folder, it first expands as if all elements belong to the parent folder, and then the child entries change style.
|
|
||
| <br> | ||
| <img class="img-responsive center-block" src="images/developer/precice-devs.png" alt="preCICE contributors" style="width: 800px; margin: auto;"> | ||
| <img class="img-fluid mx-auto d-block img-max-800" src="images/developer/precice-devs.png" alt="preCICE contributors"> |
There was a problem hiding this comment.
This image now looks significantly larger than before.
…ustomstyles-precice.css
|
@MakisH i have addressed the issues and marked the PR as ready to review . |
|
I don't know how i missed it but i accidentally raised the PR from the master branch of my fork 😅 , which can cause problems in the future . So i closed this PR and opened #922 |
2 participants
Documentation: