Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
import com.fasterxml.jackson.core.type.TypeReference;
import com.iab.openrtb.request.BidRequest;
import com.iab.openrtb.request.Imp;
import com.iab.openrtb.response.Bid;
import com.iab.openrtb.response.BidResponse;
import com.iab.openrtb.response.SeatBid;
import io.vertx.core.MultiMap;
import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
import org.prebid.server.bidder.Bidder;
import org.prebid.server.bidder.model.BidderBid;
import org.prebid.server.bidder.model.BidderCall;
Expand Down Expand Up @@ -101,16 +103,45 @@ private static List<BidderBid> bidsFromResponse(BidRequest bidRequest, BidRespon
final SeatBid firstSeatBid = bidResponse.getSeatbid().getFirst();
return CollectionUtils.emptyIfNull(firstSeatBid.getBid()).stream()
.filter(Objects::nonNull)
.map(bid -> BidderBid.of(bid, getBidType(bid.getImpid(), bidRequest.getImp()), bidResponse.getCur()))
.map(bid -> BidderBid.of(bid, getBidType(bid, bidRequest.getImp()), bidResponse.getCur()))
.toList();
}

private static BidType getBidType(String impid, List<Imp> imps) {
private static BidType getBidType(Bid bid, List<Imp> imps) {
return switch (bid.getMtype()) {
case 1 -> BidType.banner;
case 2 -> BidType.video;
case 3 -> BidType.audio;
case 4 -> BidType.xNative;
case null, default -> getBidTypeFromImp(bid, imps);
};
}

private static BidType getBidTypeFromImp(Bid bid, List<Imp> imps) {
for (Imp imp : imps) {
if (imp.getId().equals(impid) && imp.getVideo() != null) {
return BidType.video;
if (imp.getId().equals(bid.getImpid())) {
return getBidTypeFromMarkup(bid.getAdm(), imp);
}
}
return BidType.banner;
}

// Among the media types the imp offers, the markup decides: VAST is video or audio,
// a JSON object is native, anything else is banner. An imp without banner keeps its own media type.
private static BidType getBidTypeFromMarkup(String adm, Imp imp) {
final boolean isVast = StringUtils.contains(adm, "<VAST");
final boolean isJson = StringUtils.startsWith(StringUtils.trim(adm), "{");
final boolean hasBanner = imp.getBanner() != null;

if (imp.getVideo() != null && (isVast || !hasBanner)) {
return BidType.video;
}
if (imp.getAudio() != null && (isVast || !hasBanner)) {
return BidType.audio;
}
if (imp.getXNative() != null && (isJson || !hasBanner)) {
return BidType.xNative;
}
return BidType.banner;
}
}
4 changes: 4 additions & 0 deletions src/main/resources/bidder-config/smilewanted.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@ adapters:
app-media-types:
- banner
- video
- audio
- native
site-media-types:
- banner
- video
- audio
- native
supported-vendors:
vendor-id: 639
usersync:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
package org.prebid.server.bidder.smilewanted;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.iab.openrtb.request.Audio;
import com.iab.openrtb.request.Banner;
import com.iab.openrtb.request.BidRequest;
import com.iab.openrtb.request.Imp;
import com.iab.openrtb.request.Native;
import com.iab.openrtb.request.Video;
import com.iab.openrtb.response.Bid;
import com.iab.openrtb.response.BidResponse;
Expand Down Expand Up @@ -31,12 +34,17 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.assertj.core.api.Assertions.tuple;
import static org.prebid.server.proto.openrtb.ext.response.BidType.audio;
import static org.prebid.server.proto.openrtb.ext.response.BidType.banner;
import static org.prebid.server.proto.openrtb.ext.response.BidType.video;
import static org.prebid.server.proto.openrtb.ext.response.BidType.xNative;

public class SmileWantedBidderTest extends VertxTest {

private static final String ENDPOINT_URL = "https://prebid-server.smilewanted.com/java/{ZoneId}";
private static final String HTML_ADM = "<html><body><div>ad</div></body></html>";
private static final String VAST_ADM = "<?xml version=\"1.0\" encoding=\"UTF-8\"?><VAST version=\"4.1\"></VAST>";
private static final String NATIVE_ADM = "{\"ver\":\"1.2\",\"assets\":[{\"id\":1,\"title\":{\"text\":\"Title\"}}]}";

private final SmileWantedBidder target = new SmileWantedBidder(ENDPOINT_URL, jacksonMapper);

Expand Down Expand Up @@ -229,6 +237,230 @@ public void makeBidsShouldReturnBannerBidIfVideoIsAbsentInRequestImp() throws Js
.containsOnly(BidderBid.of(Bid.builder().impid("123").build(), banner, null));
}

@Test
public void makeBidsShouldReturnBannerBidIfMtypeIsBannerOnMultiFormatImp() throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenMultiFormatImp()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(1)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(1).build(), banner, null));
}

@Test
public void makeBidsShouldReturnVideoBidIfMtypeIsVideoOnMultiFormatImp() throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenMultiFormatImp()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(2)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(2).build(), video, null));
}

@Test
public void makeBidsShouldReturnBannerBidIfMtypeIsAbsentAndAdmIsHtmlOnBannerVideoImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenMultiFormatImp()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(HTML_ADM)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").adm(HTML_ADM).build(), banner, null));
}

@Test
public void makeBidsShouldReturnVideoBidIfMtypeIsAbsentAndAdmIsVastOnBannerVideoImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenMultiFormatImp()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(VAST_ADM)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").adm(VAST_ADM).build(), video, null));
}

@Test
public void makeBidsShouldReturnBannerBidIfMtypeIsAbsentAndAdmIsHtmlOnBannerAudioImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenBannerImp(impBuilder -> impBuilder.audio(Audio.builder().build()))))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(HTML_ADM)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").adm(HTML_ADM).build(), banner, null));
}

@Test
public void makeBidsShouldReturnAudioBidIfMtypeIsAbsentAndAdmIsVastOnBannerAudioImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenBannerImp(impBuilder -> impBuilder.audio(Audio.builder().build()))))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(VAST_ADM)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").adm(VAST_ADM).build(), audio, null));
}

@Test
public void makeBidsShouldReturnBannerBidIfMtypeIsAbsentAndAdmIsHtmlOnBannerNativeImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenBannerImp(impBuilder -> impBuilder.xNative(Native.builder().build()))))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(HTML_ADM)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").adm(HTML_ADM).build(), banner, null));
}

@Test
public void makeBidsShouldReturnNativeBidIfMtypeIsAbsentAndAdmIsJsonOnBannerNativeImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(givenBannerImp(impBuilder -> impBuilder.xNative(Native.builder().build()))))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(NATIVE_ADM)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").adm(NATIVE_ADM).build(), xNative, null));
}

@Test
public void makeBidsShouldReturnAudioBidIfMtypeIsAudio() throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(Imp.builder().id("123").audio(Audio.builder().build()).build()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(3)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(3).build(), audio, null));
}

@Test
public void makeBidsShouldReturnNativeBidIfMtypeIsNative() throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(Imp.builder().id("123").xNative(Native.builder().build()).build()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(4)));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(4).build(), xNative, null));
}

@Test
public void makeBidsShouldReturnAudioBidIfMtypeIsAbsentAndAudioIsPresentInRequestImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(Imp.builder().id("123").audio(Audio.builder().build()).build()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").build(), audio, null));
}

@Test
public void makeBidsShouldReturnNativeBidIfMtypeIsAbsentAndNativeIsPresentInRequestImp()
throws JsonProcessingException {
// given
final BidderCall<BidRequest> httpCall = givenHttpCall(
BidRequest.builder()
.imp(singletonList(Imp.builder().id("123").xNative(Native.builder().build()).build()))
.build(),
givenBidResponse(bidBuilder -> bidBuilder.impid("123")));

// when
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.containsOnly(BidderBid.of(Bid.builder().impid("123").build(), xNative, null));
}

@Test
public void makeBidsShouldReturnMultipleBidsFromSingleSeatBid() throws JsonProcessingException {
// given
Expand Down Expand Up @@ -350,4 +582,12 @@ private static Imp givenImp(String zoneId) {
.ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpSmilewanted.of(zoneId))))
.build();
}

private static Imp givenMultiFormatImp() {
return givenBannerImp(impBuilder -> impBuilder.video(Video.builder().build()));
}

private static Imp givenBannerImp(Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomizer) {
return impCustomizer.apply(Imp.builder().id("123").banner(Banner.builder().build())).build();
}
}