fix: default_username does not respect os_ops#389
Merged
dmitry-lipetsk merged 2 commits intoJul 10, 2026
Merged
Conversation
default_username:
- new signature is:
def default_username(os_ops: typing.Optional[OsOperations] = None) -> str:
new: default_username2 is added:
- signature is:
def default_username2(os_ops: OsOperations) -> str:
NodeConnection::__init__:
- uses default_username2(node.os_ops)
Publication::__init__:
- uses default_username2(node.os_ops)
Subscription::__init__:
- uses default_username2(node.os_ops)
Amen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default_username:
new: default_username2 is added:
NodeConnection::__init__:
Publication::__init__:
Subscription::__init__:
Amen.