Skip to content

RemoteOperations::_ensure_cmdline is corrected (typing) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-lipetsk merged 2 commits into from
May 26, 2026
+5 −8
Merged

RemoteOperations::_ensure_cmdline is corrected (typing) #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
371dc52
RemoteOperations::_ensure_cmdline is corrected (typing)
dmitry-lipetsk May 26, 2026
aaacc1d
RemoteOperations::_ensure_cmdline is updated (normalization)
dmitry-lipetsk May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/remote_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,16 +774,13 @@ def _build_cmdline(cmd, exec_env: typing.Dict = None) -> str:
return cmdline

@staticmethod
def _ensure_cmdline(cmd) -> typing.List[str]:
def _ensure_cmdline(cmd) -> str:
if type(cmd) is str:
cmd_s = cmd
elif type(cmd) is list:
cmd_s = subprocess.list2cmdline(cmd)
else:
raise ValueError("Invalid 'cmd' argument type - {0}".format(type(cmd).__name__))
return cmd
if type(cmd) is list:
return subprocess.list2cmdline(cmd)

assert type(cmd_s) is str
return cmd_s
raise ValueError("Invalid 'cmd' argument type - {0}".format(type(cmd).__name__))

@staticmethod
def _create_exec_env_list(exec_env: typing.Dict) -> typing.List[str]:
Expand Down