Skip to content

fix: avoid using uninitialized memory #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buriedpot wants to merge 3 commits into
base: master
Choose a base branch
from
+579 −11
Open

fix: avoid using uninitialized memory #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fa2417
fix: avoid using uninitialized memory
buriedpot Apr 1, 2026
f8f3b6b
Review fixes.
arseny114 May 26, 2026
06a36be
Review fixes.
arseny114 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ REGRESS = security rum rum_validate rum_hash ruminv timestamp \
int2 int4 int8 float4 float8 money oid \
time timetz date interval \
macaddr inet cidr text varchar char bytea bit varbit \
numeric rum_weight expr array
numeric rum_weight expr array rum_vacuum

TAP_TESTS = 1

Expand Down
325 changes: 325 additions & 0 deletions expected/rum_vacuum.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,325 @@
-- The test verifies that the scan in different directions in the RUM index
-- correctly handles empty posting lists and empty pages of the posting tree
-- that have been vacuumed.
SET enable_seqscan = off;
SET enable_indexscan = off;
SET enable_bitmapscan = on;
-- Prepare the data. Creating a posting list for ann and a posting tree for john.
CREATE TABLE test_rum_vacuum (id int, body tsvector);
ALTER TABLE test_rum_vacuum SET (autovacuum_enabled = false);
INSERT INTO test_rum_vacuum SELECT i, to_tsvector('ann') FROM generate_series(1, 5) i;
INSERT INTO test_rum_vacuum SELECT i, to_tsvector('john') FROM generate_series(6, 10000) i;
CREATE INDEX ON test_rum_vacuum USING rum (body rum_tsvector_ops);
-- Delete all the items from the posting list and all but one item from the
-- posting tree.
DELETE FROM test_rum_vacuum WHERE body @@ 'ann'::tsquery;
DELETE FROM test_rum_vacuum WHERE body @@ 'john'::tsquery AND id <= 9999;
-- Check the scan before vacuum.
-- Scan with the extraction of results from the posting list (RumFastScan mode).
EXPLAIN (costs off)
SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('ann');
QUERY PLAN
-------------------------------------------------------
Bitmap Heap Scan on test_rum_vacuum
Recheck Cond: (body @@ to_tsquery('ann'::text))
-> Bitmap Index Scan on test_rum_vacuum_body_idx
Index Cond: (body @@ to_tsquery('ann'::text))
(4 rows)

SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('ann');
id | body
----+------
(0 rows)

-- Scan with the extraction of results from the posting tree (RumFastScan mode).
EXPLAIN (costs off)
SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
QUERY PLAN
--------------------------------------------------------
Bitmap Heap Scan on test_rum_vacuum
Recheck Cond: (body @@ to_tsquery('john'::text))
-> Bitmap Index Scan on test_rum_vacuum_body_idx
Index Cond: (body @@ to_tsquery('john'::text))
(4 rows)

SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
id | body
-------+----------
10000 | 'john':1
(1 row)

-- Full-pass index scan (RumFullScan mode).
EXPLAIN (costs off)
SELECT id, body, body <=> to_tsquery('john') AS distance FROM test_rum_vacuum ORDER BY distance;
QUERY PLAN
--------------------------------------------------------------
Index Scan using test_rum_vacuum_body_idx on test_rum_vacuum
Order By: (body <=> to_tsquery('john'::text))
(2 rows)

SELECT id, body, body <=> to_tsquery('john') AS distance FROM test_rum_vacuum ORDER BY distance;
id | body | distance
-------+----------+----------
10000 | 'john':1 | 16.44934
(1 row)

-- Remove the elements from the posting tree and the posting list and make the
-- same checks.
VACUUM test_rum_vacuum;
-- Scan of an empty posting list.
EXPLAIN (costs off)
SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('ann');
QUERY PLAN
-------------------------------------------------------
Bitmap Heap Scan on test_rum_vacuum
Recheck Cond: (body @@ to_tsquery('ann'::text))
-> Bitmap Index Scan on test_rum_vacuum_body_idx
Index Cond: (body @@ to_tsquery('ann'::text))
(4 rows)

SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('ann');
id | body
----+------
(0 rows)

-- After the vacuum, the left and right leaf pages will remain in the posting
-- tree (because the outermost pages are not deleted). The left page is empty,
-- and the right page has one element. Check that the scan skips an left empty
-- page and receives an item from the right non-empty page.
EXPLAIN (costs off)
SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
QUERY PLAN
--------------------------------------------------------
Bitmap Heap Scan on test_rum_vacuum
Recheck Cond: (body @@ to_tsquery('john'::text))
-> Bitmap Index Scan on test_rum_vacuum_body_idx
Index Cond: (body @@ to_tsquery('john'::text))
(4 rows)

SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
id | body
-------+----------
10000 | 'john':1
(1 row)

-- Check that in RumFullScan mode, the scan correctly switches from an empty
-- posting list to a non-empty posting tree and receives 1 element.
EXPLAIN (costs off)
SELECT id, body, body <=> to_tsquery('john') AS distance FROM test_rum_vacuum ORDER BY distance;
QUERY PLAN
--------------------------------------------------------------
Index Scan using test_rum_vacuum_body_idx on test_rum_vacuum
Order By: (body <=> to_tsquery('john'::text))
(2 rows)

SELECT id, body, body <=> to_tsquery('john') AS distance FROM test_rum_vacuum ORDER BY distance;
id | body | distance
-------+----------+----------
10000 | 'john':1 | 16.44934
(1 row)

-- Delete the last item from the posting tree.
DELETE FROM test_rum_vacuum WHERE body @@ 'john'::tsquery;
VACUUM test_rum_vacuum;
-- Check that the scan correctly skips all empty posting tree pages, reaches
-- the far right and ends.
EXPLAIN (costs off)
SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
QUERY PLAN
--------------------------------------------------------
Bitmap Heap Scan on test_rum_vacuum
Recheck Cond: (body @@ to_tsquery('john'::text))
-> Bitmap Index Scan on test_rum_vacuum_body_idx
Index Cond: (body @@ to_tsquery('john'::text))
(4 rows)

SELECT * FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
id | body
----+------
(0 rows)

-- Check that in RumFullScan mode, the scan correctly skips an empty posting
-- list and an empty posting tree.
EXPLAIN (costs off)
SELECT id, body, body <=> to_tsquery('john') AS distance FROM test_rum_vacuum ORDER BY distance;
QUERY PLAN
--------------------------------------------------------------
Index Scan using test_rum_vacuum_body_idx on test_rum_vacuum
Order By: (body <=> to_tsquery('john'::text))
(2 rows)

SELECT id, body, body <=> to_tsquery('john') AS distance FROM test_rum_vacuum ORDER BY distance;
id | body | distance
----+------+----------
(0 rows)

-- Check that after the reinsertion, the new data can be found in the posting
-- list and posting tree.
INSERT INTO test_rum_vacuum SELECT i, to_tsvector('ann') FROM generate_series(10001, 10005) i;
INSERT INTO test_rum_vacuum SELECT i, to_tsvector('john') FROM generate_series(10006, 20000) i;
EXPLAIN (costs off)
SELECT count(*) FROM test_rum_vacuum WHERE body @@ to_tsquery('ann');
QUERY PLAN
-------------------------------------------------------------
Aggregate
-> Bitmap Heap Scan on test_rum_vacuum
Recheck Cond: (body @@ to_tsquery('ann'::text))
-> Bitmap Index Scan on test_rum_vacuum_body_idx
Index Cond: (body @@ to_tsquery('ann'::text))
(5 rows)

SELECT count(*) FROM test_rum_vacuum WHERE body @@ to_tsquery('ann');
count
-------
5
(1 row)

EXPLAIN (costs off)
SELECT count(*) FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
QUERY PLAN
--------------------------------------------------------------
Aggregate
-> Bitmap Heap Scan on test_rum_vacuum
Recheck Cond: (body @@ to_tsquery('john'::text))
-> Bitmap Index Scan on test_rum_vacuum_body_idx
Index Cond: (body @@ to_tsquery('john'::text))
(5 rows)

SELECT count(*) FROM test_rum_vacuum WHERE body @@ to_tsquery('john');
count
-------
9995
(1 row)

DROP TABLE test_rum_vacuum;
-- Check the backward scan direction.
SET enable_bitmapscan = off;
SET enable_indexscan = on;
-- Prepare the data. Creating a posting list for ann and a posting tree for john.
CREATE TABLE test_rum_vacuum_backward (id int, body tsvector);
ALTER TABLE test_rum_vacuum_backward SET (autovacuum_enabled = false);
INSERT INTO test_rum_vacuum_backward SELECT i, to_tsvector('ann') FROM generate_series(1, 5) i;
INSERT INTO test_rum_vacuum_backward SELECT i, to_tsvector('john') FROM generate_series(6, 10000) i;
CREATE INDEX ON test_rum_vacuum_backward USING rum (body rum_tsvector_addon_ops, id) WITH (attach='id', to='body', order_by_attach='true');
-- Delete all the items from the posting list and all but one item from the
-- posting tree.
DELETE FROM test_rum_vacuum_backward WHERE body @@ 'ann'::tsquery;
DELETE FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery AND id <= 9999;
-- Check the backward scan before vacuum.
-- A scan with the results extracted from the posting list (in the backward direction).
EXPLAIN (costs off)
SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'ann'::tsquery ORDER BY distance;
QUERY PLAN
-----------------------------------------------------------------------------------
Index Scan using test_rum_vacuum_backward_body_id_idx on test_rum_vacuum_backward
Index Cond: (body @@ '''ann'''::tsquery)
Order By: (id <=| 2)
(3 rows)

SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'ann'::tsquery ORDER BY distance;
id | body | distance
----+------+----------
(0 rows)

-- A scan with the results extracted from the posting tree (in the backward direction).
EXPLAIN (costs off)
SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY distance;
QUERY PLAN
-----------------------------------------------------------------------------------
Index Scan using test_rum_vacuum_backward_body_id_idx on test_rum_vacuum_backward
Index Cond: (body @@ '''john'''::tsquery)
Order By: (id <=| 2)
(3 rows)

SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY distance;
id | body | distance
-------+----------+----------
10000 | 'john':1 | Infinity
(1 row)

-- Remove the elements from the posting tree and the posting list and make the
-- same checks.
VACUUM test_rum_vacuum_backward;
EXPLAIN (costs off)
SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'ann'::tsquery ORDER BY distance;
QUERY PLAN
-----------------------------------------------------------------------------------
Index Scan using test_rum_vacuum_backward_body_id_idx on test_rum_vacuum_backward
Index Cond: (body @@ '''ann'''::tsquery)
Order By: (id <=| 2)
(3 rows)

SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'ann'::tsquery ORDER BY distance;
id | body | distance
----+------+----------
(0 rows)

EXPLAIN (costs off)
SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY distance;
QUERY PLAN
-----------------------------------------------------------------------------------
Index Scan using test_rum_vacuum_backward_body_id_idx on test_rum_vacuum_backward
Index Cond: (body @@ '''john'''::tsquery)
Order By: (id <=| 2)
(3 rows)

SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY distance;
id | body | distance
-------+----------+----------
10000 | 'john':1 | Infinity
(1 row)

-- Delete the last item from the posting tree and make the same check.
DELETE FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery;
VACUUM test_rum_vacuum_backward;
EXPLAIN (costs off)
SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY distance;
QUERY PLAN
-----------------------------------------------------------------------------------
Index Scan using test_rum_vacuum_backward_body_id_idx on test_rum_vacuum_backward
Index Cond: (body @@ '''john'''::tsquery)
Order By: (id <=| 2)
(3 rows)

SELECT *, id <=| 2 AS distance FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY distance;
id | body | distance
----+------+----------
(0 rows)

-- Check that after the reinsertion, the new data can be found in the posting
-- list and posting tree.
INSERT INTO test_rum_vacuum_backward SELECT i, to_tsvector('ann') FROM generate_series(10001, 10005) i;
INSERT INTO test_rum_vacuum_backward SELECT i, to_tsvector('john') FROM generate_series(10006, 20000) i;
EXPLAIN (costs off)
SELECT count(*) FROM (SELECT * FROM test_rum_vacuum_backward WHERE body @@ 'ann'::tsquery ORDER BY id <=| 2);
QUERY PLAN
-----------------------------------------------------------------------------------------
Aggregate
-> Index Scan using test_rum_vacuum_backward_body_id_idx on test_rum_vacuum_backward
Index Cond: (body @@ '''ann'''::tsquery)
Order By: (id <=| 2)
(4 rows)

SELECT count(*) FROM (SELECT * FROM test_rum_vacuum_backward WHERE body @@ 'ann'::tsquery ORDER BY id <=| 2);
count
-------
5
(1 row)

EXPLAIN (costs off)
SELECT count(*) FROM (SELECT * FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY id <=| 2);
QUERY PLAN
-----------------------------------------------------------------------------------------
Aggregate
-> Index Scan using test_rum_vacuum_backward_body_id_idx on test_rum_vacuum_backward
Index Cond: (body @@ '''john'''::tsquery)
Order By: (id <=| 2)
(4 rows)

SELECT count(*) FROM (SELECT * FROM test_rum_vacuum_backward WHERE body @@ 'john'::tsquery ORDER BY id <=| 2);
count
-------
9995
(1 row)

DROP TABLE test_rum_vacuum_backward;
Loading