Repository navigation
Use v1 bootstrap endpoint, falling back to experimental - #879
Merged
Merged
Conversation
Fixes #594 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #594
rsconnect bootstrapcallsPOST /__api__/v1/bootstrap(available since Connect 2024.05.0). If that returns 404, it retries the deprecatedPOST /__api__/v1/experimental/bootstrap, so bootstrap keeps working against older Connect versions. Unauthenticated requests can't read the server version, so the fallback is based on the 404 rather than a version check.Tests:
test_bootstrap_experimental_fallbackcovers v1 404 → experimental success.test_bootstrap_not_found_errorreturns 404 from both endpoints.Integration tests passing confirms that it works across a range of Connect versions. They will bomb hard if it can't bootstrap.