fix: tolerate NULL state$values in onBookmark callback - #287
Merged
Conversation
When shinychat's history save triggers the bookmark, state$values can be NULL, and utils::modifyList() requires a list. Coalesce to an empty list before merging the querychat state snapshot.
cpsievert
force-pushed
the
fix/bookmark-null-values
branch
from
September 5, 2026 01:13
f1cf0ff to
c6ebd17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With chat history enabled, submitting a prompt can produce:
shinychat's history save triggers a Shiny bookmark (
session$doBookmark()) after each response. In that context theonBookmarkcallback'sstate$valuescan beNULL, bututils::modifyList(NULL, ...)fails becausemodifyList()requires a list as its first argument.Repro
Observed in
querychat_app(penguins)with default (file-based) history after submitting a prompt.Fix
Coalesce
state$valuesto an empty list before merging the state snapshot:Includes a regression test that drives
mod_serverviatestServerand invokes the capturedonBookmarkcallback withstate$values <- NULL.