Add --title flag and polish attestation rendering#290
Draft
stevenolen wants to merge 1 commit into
Draft
Conversation
- New --title flag on `ptd attestation` overrides the document title (default unchanged: "Installation Confirmation — <target>"). Useful when a workload name does not match what a customer expects to see at the top of the document. - Widen the Identity Provider column in the PDF so long OIDC issuer URLs are not truncated; rebalance auth table widths from [4,3,5] to [3,1,8] since the Method column only needs to fit short strings like "oidc". - Surface the generation timestamp near the Sign-Off block in both the markdown and PDF renderers, and pre-fill the Prepared By date with the generation date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three small improvements to
ptd attestationdriven by customer feedback on a generated document.--titleflag overrides the rendered document title. Default behavior is unchanged: when the flag is not set, the title remains"Installation Confirmation — <target>". The flag is helpful when the internal workload name does not match the identifier a recipient expects at the top of the document.[4, 3, 5]truncated long OIDC issuer URLs (e.g. Entra ID tenant URLs). Rebalanced to[3, 1, 8]since the Method column only renders short strings likeoidc.Code Flow
AttestationDatagains aTitlefield and aDisplayTitle()method. The renderers (markdown.go,pdf.go) now callDisplayTitle()instead of inlining the default. The CLI setsdata.Titlefrom the new flag before invoking the renderers.PdfSignatureRownow takes an optionaldateargument so the sign-off row can be pre-filled.Category of change
Checklist
Verification
just test-lib(attestation package tests pass)just clibuilds cleanlyptd attestation --helpshows the new flag with the documented default