fix: use azurecli login for AKS kubeconfig and fix az symlink in symlink-binaries#288
Draft
amdove wants to merge 1 commit into
Draft
fix: use azurecli login for AKS kubeconfig and fix az symlink in symlink-binaries#288amdove wants to merge 1 commit into
amdove wants to merge 1 commit into
Conversation
…ink-binaries setupAzureKubeConfig was writing raw AKS kubeconfig bytes directly to disk, bypassing BuildAKSKubeconfigString which replaces --login devicecode with --login azurecli. This caused kubelogin to prompt for device code auth on every kubectl/k9s invocation even with a valid az session. symlink-binaries was creating a symlink to /usr/bin/az, which is a bash script that uses BASH_SOURCE-relative paths to find its Python interpreter — a symlink breaks that calculation. Now writes a wrapper script that calls Python directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupAzureKubeConfig was writing raw AKS kubeconfig bytes directly to disk,
bypassing BuildAKSKubeconfigString which replaces --login devicecode with
--login azurecli. This caused kubelogin to prompt for device code auth on every
kubectl/k9s invocation even with a valid az session.
symlink-binaries was creating a symlink to /usr/bin/az, which is a bash script
that uses BASH_SOURCE-relative paths to find its Python interpreter — a symlink
breaks that calculation. Now writes a wrapper script that calls Python directly.
Description
Code Flow
Category of change
Checklist