fix: tune Azure NetApp workbench-shared volumes and enable backup enforcement#285
Merged
Conversation
…orcement The workbench-shared volume is used for inter-process communication between Workbench sessions, not for storing user data. It does not need large capacity or backup/snapshot protection. - Revert workbench-shared default capacity from 200 GiB to 50 GiB - Skip data_protection (backups and snapshots) for workbench-shared volumes - Set policy_enforced=True on volume backup properties so the backup policy is actually active on volumes that do need protection
amdove
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workbench-shared NetApp volume is used for inter-process communication between Workbench sessions (e.g. rserver socket coordination), not for storing user data. It doesn't need large capacity or backup/snapshot protection.
policy_enforced=Trueon volume backup properties — without this flag, the backup policy is attached but not actually enforced. This fixes backups being in a disabled state on volumes that do need protection (connect, workbench).Test plan
just test-python-pulumipasses (187 tests)ptd ensure <target> --only-steps persistent --dry-runshows workbench-shared volumes unchanged at 50 GiB with nodataProtectionblockptd ensure <target> --only-steps persistent --dry-runshows connect/workbench volumes gainpolicyEnforced: true