Open
Conversation
…hetics When annotation layers have no required aesthetics (e.g., rule geom) and only non-positional scalar parameters, process_annotation_layer now adds a dummy column to generate valid SQL instead of malformed empty VALUES clause. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
teunbrand
commented
Mar 20, 2026
| /// This method is called during layer execution to allow geoms to customize | ||
| /// how aesthetics and parameters should be treated. The default implementation | ||
| /// does nothing. | ||
| fn setup_layer( |
Collaborator
Author
There was a problem hiding this comment.
I thought this would be a nice hook for layers to check combinations of parameters and combinations of aeshtetics. A bunch of such checks are in the writer, but they'd generalise to other writers too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #220.
It adds
slopeandinterceptparameters to therulelayer, and removes thelinearlayer.At time of writing, I still have to trivialise
interceptper discussion.