Merged
Conversation
Adds comprehensive tests for map_internal_to_user() method and validation error messages to ensure internal aesthetic names (pos1, pos2, facet1) are correctly translated to user-facing names (x, y, panel) in error messages. Tests cover: - Cartesian coordinates (x, y and variants) - Polar coordinates (theta, radius) - Facet aesthetics (panel, row, column) - Roundtrip conversion (user -> internal -> user) - Validation error messages for missing and unsupported aesthetics Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #120.
Instead of just checking if required aesthetics are present, we now also check if the mapping has unsupported entries.
An extra AestheticContext method was needed to report user-facing position aesthetics.