Repository navigation
fix(csharp): compile record fields named Equals, GetHashCode, and ToString - #133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UCI's
QueryPEThas anEqualsfield, which becomes an invalid positional C# record member and fails with CS8866. Generated properties namedEquals,GetHashCode, orToStringnow receive aValuesuffix before normal collision handling; XML names remain unchanged.A generated-runtime regression checks all three names plus an explicit
EqualsValuecollision in both record and mutable-class models. The full UCI C# output now compiles under the 3500 MiB cgroup budget.Validation: Rust format, strict workspace Clippy, codegen/schema/CLI tests, seven-language smoke, Python lint/format, and 112 Python tests with 100% statement/branch coverage passed. C# runtime tests used .NET 10 roll-forward; the corpus build targeted net8.0. Companion W3C CType: 31/31 schema compilations, 23/28 Python instance checks (five unresolved instance failures).
Part of polyxml/polyxml-schema-corpus#1. Rust UCI compilation still exceeds the 3500 MiB gate budget, so that issue is not resolved by this change alone.