feat: install multiple runtimes from devEngines.runtime - #32
feat: install multiple runtimes from devEngines.runtime#32BlankParticle wants to merge 2 commits into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 37 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2026-05-11T16:19:49.450ZApplied to files:
📚 Learning: 2026-08-09T14:55:39.968ZApplied to files:
🔇 Additional comments (7)
📝 WalkthroughWalkthroughThe action now installs all valid ChangesMulti-runtime installation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR adds support for installing multiple runtimes from devEngines.runtime, with no actionable merge-blocking risk currently identified beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Action
participant RuntimeResolver
participant RuntimeInstaller
participant Outputs
participant PnpmInstall
Action->>RuntimeResolver: Resolve explicit or manifest runtimes
RuntimeResolver->>RuntimeInstaller: Install each runtime
RuntimeInstaller-->>Action: Return installed runtime records
Action->>Outputs: Set first runtime and runtimes JSON output
Action->>PnpmInstall: Run install with runtime-installed state
PnpmInstall-->>Action: Append --no-runtime when runtimes were installed
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Confidence Score: 4/5The PR is not yet safe to merge because a runtime download failure still aborts the action despite a non-fatal devEngines onFail policy. Runtime entries discard onFail, and installRuntime marks every installation error as failed before runMain returns early, leaving the previously reported failure behavior reachable. Files Needing Attention: src/index.ts, src/install-runtime/index.ts Reviews (3): Last reviewed commit: "fix: dedupe runtime versions" | Re-trigger Greptile |
c689cee to
0447c75
Compare
We have a repo setup where we use
pnpmas package manager and both Node and Bun as runtime, I was moving to usepnpm/setupaction as it seems the one we should be using now.So this is what I put in our
package.jsonBut when the action runs, it only installed
pnpmandbun, and the nodejs version resolved to the preinstalled version on the container. I figured out that it only installs the first runtime if the runtime is an array. So this is the workaround we have for nowWe need to install node before running install since we have postinstall that needs node 24
So, this PR adds supports for installing multiple runtimes without breaking any old consumers of this action
Summary by CodeRabbit
New Features
runtimesoutput containing all installed runtimes in order.Bug Fixes
Documentation