Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Validation update (Windows): The changed path-extender-windows Jest suite passes 11/11 tests using Node 22.14.0 and the dependency versions pinned by this workspace. In an isolated Jest/ts-jest harness, the other runnable suites also pass (11 suites, 101 tests total). The remaining log/group suite cannot start in that harness because its existing ci-info mock hits a ts-jest hoisting/initialization error; it is unrelated to this diff. The repository's official bit install / bit test still cannot run: .bitmap requires pnpm.env/envs/pnpm-env@3.1.0, while bit show --remote reports 2.1.0 as the latest published version and an explicit import of 3.1.0 returns missingIds. This was reproduced with the CI-pinned Bit 1.9.76. No repository files were changed for this validation. |
Summary
pnpm setupcan corrupt non-ASCII Windows PATH entries when it rewrites the registry. Itschcp 65001call currently runs in a separate hidden console, leavingreg queryon the original code page. This change runs code-page detection, switching, and restoration in the same console asreg.Related: pnpm/pnpm#6346.
Validation
chcp 65001left the next child at 949. WithwindowsHide: false, the next child used 65001. The original page was restored after the check.C:\Users\Jozef Steinhübl\binand confirmed all threechcpcalls usewindowsHide: false.bit installfailed to importpnpm.env/envs/pnpm-env@3.1.0from the remote scope. CI validation is still needed.