Skip to content
This repository was archived by the owner on Sep 26, 2026. It is now read-only.

fix: preserve unicode paths during windows setup - #31

Open
newmind wants to merge 1 commit into
pnpm:mainfrom
newmind:fix/windows-unicode-setup-6346
Open

newmind wants to merge 1 commit into
pnpm:mainfrom
newmind:fix/windows-unicode-setup-6346

Conversation

@newmind

@newmind newmind commented Sep 25, 2026

Copy link
Copy Markdown

Summary

pnpm setup can corrupt non-ASCII Windows PATH entries when it rewrites the registry. Its chcp 65001 call currently runs in a separate hidden console, leaving reg query on the original code page. This change runs code-page detection, switching, and restoration in the same console as reg.

Related: pnpm/pnpm#6346.

Validation

  • On Windows with code page 949, a hidden chcp 65001 left the next child at 949. With windowsHide: false, the next child used 65001. The original page was restored after the check.
  • An isolated run of the updated TypeScript source preserved C:\Users\Jozef Steinhübl\bin and confirmed all three chcp calls use windowsHide: false.
  • The Bit test suite could not run: bit install failed to import pnpm.env/envs/pnpm-env@3.1.0 from the remote scope. CI validation is still needed.

Compound Engineering

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 181430fd-2654-4aad-8552-c977d2e25cf9


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@newmind
newmind marked this pull request as ready for review September 25, 2026 15:50
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@newmind

newmind commented Sep 26, 2026

Copy link
Copy Markdown
Author

Validation update (Windows): The changed path-extender-windows Jest suite passes 11/11 tests using Node 22.14.0 and the dependency versions pinned by this workspace. In an isolated Jest/ts-jest harness, the other runnable suites also pass (11 suites, 101 tests total). The remaining log/group suite cannot start in that harness because its existing ci-info mock hits a ts-jest hoisting/initialization error; it is unrelated to this diff. The repository's official bit install / bit test still cannot run: .bitmap requires pnpm.env/envs/pnpm-env@3.1.0, while bit show --remote reports 2.1.0 as the latest published version and an explicit import of 3.1.0 returns missingIds. This was reproduced with the CI-pinned Bit 1.9.76. No repository files were changed for this validation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant