This repository was archived by the owner on Sep 26, 2026. It is now read-only.
fix(windows): repair legacy PNPM_HOME registry type - #30
Draft
amishabenramani wants to merge 1 commit into
Draft
amishabenramani wants to merge 1 commit into
amishabenramani wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair the registry type left by older Windows pnpm installations when
PNPM_HOMEalready contains the requested path. Previously, the updater compared only the data and skipped an existingREG_EXPAND_SZ; it now also checks the type and writesREG_SZwhen needed.Refs pnpm/pnpm#5696. This fixes the shared TypeScript component used by pnpm v11. A companion change is being prepared in pnpm's Rust implementation. The component will need a release and dependency uptake before this repair reaches pnpm v11.
Behavior and scope
PNPM_HOMEwithout force.Pathand avoid inserting its existing entry again.The existing skipped-value fixture now uses
REG_SZ. A separate regression suite covers the legacy type, repeated setup, both types with a conflicting path, forced overwrite, and a failed write.Verification
Native Windows x64, Node 25.2.1, using the real checked-out source and spec files with a task-local Jest 29.7 / ts-jest runner:
git diff --check: passed.All registry and code-page commands are mocked; no persistent user environment was modified. The complete Bit workspace/CI pipeline has not been run locally. This PR remains draft pending that CI verification and companion coordination.
Written by an agent (ChatGPT, GPT-6 Astra Pro).