fix(web): exact-match transform function names in style key regex#2515
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
joshuaellis
force-pushed
the
next
branch
2 times, most recently
from
622c16d to
9ef804a
Compare
User-defined style keys with prefixes like 'scale3dValue' or 'translateMe' were hijacked by the prefix-based regex in AnimatedStyle, emitted as invalid CSS, and silently dropped by the browser along with the composed transform. Anchor the regex and enumerate the exact CSS transform-function names from MDN so only documented functions are picked up. Closes #1912
joshuaellis
force-pushed
the
fix/issue-1912
branch
from
28d7e4e to
ca82436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1912.
Summary
User-defined style keys like
scale3dValueortranslateY_v2were hijacked by the^(matrix|translate|scale|rotate|skew)prefix match inAnimatedStyle, then emitted as invalid CSS (e.g.scale3dValue(0.5)), which the browser silently drops — taking the rest of the composedtransformwith it.The fix anchors the regex with
$and enumerates the exact CSS transform-function names from MDN:/^(matrix3d|matrix|translate3d|translate[XYZ]?|scale3d|scale[XYZ]?|rotate3d|rotate[XYZ]?|skew[XY]?)$/Any other key now passes through as a regular style prop.